Replaces the separate SQL-only /query and text-only /search endpoints with one pipe-syntax query language (plus raw SQL escape hatch) that compiles to a single IR and execution plan across both backends, so a query like `message:"connection refused" | stats count by host` runs as one request instead of two disjoint tools. - api/internal/querylang: lexer -> ast -> parser -> ir -> planner -> executor, each layer independently tested. - Execution generalizes Phase 1's proven Tantivy-prefilter pattern into a 4-way routing table (pure ClickHouse / text-only / text + aggregation / raw SQL passthrough). - Unified web query page and `sentryctl query`, both hitting the same POST /query endpoint. - Benchmarked against a real 1,022,000-row dataset (hack/benchmark-fixture); caught and fixed a real bug where the Tantivy prefilter cap (10,000) produced an IN-clause exceeding ClickHouse's default max_query_size -- lowered to 5,000, documented in docs/query-language-design.md and docs/phase-2-runbook.md. - docs/query-language-reference.md: customer-facing syntax reference.
135 lines
4.4 KiB
Go
135 lines
4.4 KiB
Go
// Package queryapi is Sentry's query API: a single POST /query endpoint
|
|
// accepting either the pipe syntax or raw SQL, compiled by
|
|
// querylang/planner and executed by querylang/executor. Replaces Phase
|
|
// 0/1's two separate placeholder endpoints (raw-SQL-only /query,
|
|
// free-text-only /search) -- see /docs/query-language-design.md.
|
|
//
|
|
// Still plain net/http, not the pinned gRPC+REST-gateway pattern, for
|
|
// the same reason as Phase 0/1: this is one endpoint, and the
|
|
// proto/annotations/codegen machinery doesn't buy much at that size.
|
|
// `/api` does speak gRPC internally (to /search) — this simplification
|
|
// is about the public-facing surface only.
|
|
package queryapi
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/sentry/sentry/api/internal/querylang/executor"
|
|
"github.com/sentry/sentry/api/internal/querylang/planner"
|
|
)
|
|
|
|
type Handler struct {
|
|
logger *slog.Logger
|
|
sqlRunner executor.SQLRunner
|
|
search executor.SearchClient
|
|
queryTimeout time.Duration
|
|
allowedOrigin string
|
|
}
|
|
|
|
func NewHandler(logger *slog.Logger, sqlRunner executor.SQLRunner, search executor.SearchClient, queryTimeout time.Duration, allowedOrigin string) *Handler {
|
|
return &Handler{logger: logger, sqlRunner: sqlRunner, search: search, queryTimeout: queryTimeout, allowedOrigin: allowedOrigin}
|
|
}
|
|
|
|
func (h *Handler) Routes() http.Handler {
|
|
mux := http.NewServeMux()
|
|
mux.HandleFunc("POST /query", h.handleQuery)
|
|
mux.HandleFunc("GET /healthz", h.handleHealthz)
|
|
return h.withCORS(mux)
|
|
}
|
|
|
|
// withCORS is deliberately permissive by default (see CORSAllowedOrigin in
|
|
// internal/config) since there's no auth yet and the SvelteKit dev server
|
|
// runs on a different origin. Tighten alongside adding real auth.
|
|
func (h *Handler) withCORS(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Access-Control-Allow-Origin", h.allowedOrigin)
|
|
w.Header().Set("Access-Control-Allow-Methods", "POST, OPTIONS")
|
|
w.Header().Set("Access-Control-Allow-Headers", "Content-Type")
|
|
if r.Method == http.MethodOptions {
|
|
w.WriteHeader(http.StatusNoContent)
|
|
return
|
|
}
|
|
next.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
func (h *Handler) handleHealthz(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
}
|
|
|
|
type queryRequest struct {
|
|
Query string `json:"query"`
|
|
// Language overrides auto-detection ("" / omitted). "sql" or "spl" --
|
|
// see planner.Language and /docs/query-language-design.md's
|
|
// "Detection" section for why this exists: the rare case a pipe
|
|
// query legitimately starts with the literal word "select".
|
|
Language string `json:"language"`
|
|
}
|
|
|
|
type queryResponse struct {
|
|
Columns []string `json:"columns"`
|
|
Rows [][]any `json:"rows"`
|
|
}
|
|
|
|
type errorResponse struct {
|
|
Error string `json:"error"`
|
|
}
|
|
|
|
// maxBodyBytes caps the request body: a query string has no legitimate
|
|
// reason to be larger than this.
|
|
const maxBodyBytes = 1 << 20 // 1 MiB
|
|
|
|
func (h *Handler) handleQuery(w http.ResponseWriter, r *http.Request) {
|
|
r.Body = http.MaxBytesReader(w, r.Body, maxBodyBytes)
|
|
|
|
var req queryRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid JSON body: "+err.Error())
|
|
return
|
|
}
|
|
if strings.TrimSpace(req.Query) == "" {
|
|
writeError(w, http.StatusBadRequest, "query must not be empty")
|
|
return
|
|
}
|
|
|
|
lang := planner.Language(req.Language)
|
|
if lang != planner.Auto && lang != planner.SQL && lang != planner.SPL {
|
|
writeError(w, http.StatusBadRequest, `language must be "sql", "spl", or omitted`)
|
|
return
|
|
}
|
|
|
|
plan, err := planner.Compile(req.Query, lang, time.Now())
|
|
if err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(r.Context(), h.queryTimeout)
|
|
defer cancel()
|
|
|
|
result, err := executor.Execute(ctx, plan, h.sqlRunner, h.search)
|
|
if err != nil {
|
|
h.logger.Error("query execution failed", "query", req.Query, "error", err)
|
|
writeError(w, http.StatusBadGateway, "query failed: "+err.Error())
|
|
return
|
|
}
|
|
|
|
writeJSON(w, queryResponse{Columns: result.Columns, Rows: result.Rows})
|
|
}
|
|
|
|
func writeJSON(w http.ResponseWriter, v any) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
_ = json.NewEncoder(w).Encode(v)
|
|
}
|
|
|
|
func writeError(w http.ResponseWriter, status int, msg string) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.WriteHeader(status)
|
|
_ = json.NewEncoder(w).Encode(errorResponse{Error: msg})
|
|
}
|