Document the fork CI approval gate in CONTRIBUTING.md
Belongs with the commit before it and was left out of it by mistake. The repository's fork-pr-contributor-approval policy is now all_external_contributors rather than GitHub's first_time_contributors default, so every run on an outside contributor's branch waits to be started by hand instead of only their first one. A contributor who does not know that reads a build check that never appears as an orphaned run -- which this repository has had, during the 2026-08-26 Actions outage -- and pushes again to shake it loose. Neither that nor reopening the PR starts it, so say so where the other main protection notes are.
This commit is contained in:
@@ -58,6 +58,12 @@ check has passed — not afterwards — and the branch cannot be force-pushed or
|
|||||||
deleted. No approving review is required, so a PR of your own is not blocked
|
deleted. No approving review is required, so a PR of your own is not blocked
|
||||||
waiting for one.
|
waiting for one.
|
||||||
|
|
||||||
|
**CI on a PR from a fork waits to be approved.** Every workflow run on an
|
||||||
|
outside contributor's branch sits at *awaiting approval* until a maintainer
|
||||||
|
starts it by hand, so the **build** check will not appear the moment you open
|
||||||
|
the PR — that is the gate working, not a broken run. Pushing again will not
|
||||||
|
start it, and neither will closing and reopening.
|
||||||
|
|
||||||
### Code Style
|
### Code Style
|
||||||
|
|
||||||
- Match the existing formatting and naming conventions used elsewhere in the codebase.
|
- Match the existing formatting and naming conventions used elsewhere in the codebase.
|
||||||
|
|||||||
Reference in New Issue
Block a user