coffey-labs/ihasmail
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 2 Wiki Activity

Stalwart has not reached 1.0 yet

Browse Source 
Both the versioning comment and the README described 1.0 in the past
tense, which reads as though it has shipped and the numbering was
changed in response. It has not. The old `2.16.x` scheme was dropped
over where it would end up, not where it ended up, and the surrounding
conditionals are simplified to match: "would sort", "would read", rather
than "would have".

The badge quoted in the comment also said 0.16.19; it says 0.16.20 now.

Comments and prose only -- no behaviour changes.
This commit is contained in:
jcoffey-dev
2026-08-30 21:22:07 -07:00
parent 12157f47bf
commit b0cb73a924
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+3 -3
View File
@@ -181,9 +181,9 @@ to look wrong: a version with no `+pr` or `+g` means whoever built the image did
not pass one. not pass one.
The version says nothing about Stalwart, deliberately. It used to: `2.16.x` had The version says nothing about Stalwart, deliberately. It used to: `2.16.x` had
`16` for the 0.16 generation it targeted, which left nowhere to go when Stalwart `16` for the 0.16 generation it targeted, which leaves nowhere to go once
reached 1.0 — `2.1` sorts *below* the `2.16` already deployed, so every image and Stalwart reaches 1.0 — `2.1` sorts *below* the `2.16` already deployed, so every
About screen would have read as a downgrade. Which Stalwart a build needs is image and About screen would read as a downgrade. Which Stalwart a build needs is
stated where it can be precise, in the badge at the top of this file and in stated where it can be precise, in the badge at the top of this file and in
[KNOWN-ISSUES.md](KNOWN-ISSUES.md), rather than compressed into one digit. [KNOWN-ISSUES.md](KNOWN-ISSUES.md), rather than compressed into one digit.
scripts/version.mjs
+4 -4
View File
@@ -5,12 +5,12 @@
* +pr129 the pull request it arrived through * +pr129 the pull request it arrived through
* *
* The date leads because ihasmail's version used to be `2.16.<pr>`, where `16` * The date leads because ihasmail's version used to be `2.16.<pr>`, where `16`
* was the Stalwart generation it targeted -- and Stalwart 1.0 leaves that with * was the Stalwart generation it targeted -- and Stalwart 1.0 will leave that
* nowhere to go. `2.1` would have sorted *below* the `2.16` already deployed, * with nowhere to go. `2.1` would sort *below* the `2.16` already deployed, so
* so every image and About screen would have read as a downgrade. Tying our * every image and About screen would read as a downgrade. Tying our
* numbering to somebody else's was the mistake; which Stalwart a build needs is * numbering to somebody else's was the mistake; which Stalwart a build needs is
* said properly in the README badge and KNOWN-ISSUES, where it can be precise * said properly in the README badge and KNOWN-ISSUES, where it can be precise
* ("0.16 or newer; tested against 0.16.19") rather than one digit. * ("0.16 or newer; tested against 0.16.20") rather than one digit.
* *
* The pull request moved into build metadata, after the `+`, because it is * The pull request moved into build metadata, after the `+`, because it is
* provenance rather than a position in a sequence: at a hundred merges a week * provenance rather than a position in a sequence: at a hundred merges a week