jcoffey-dev
3eb0f4c589
RBAC (api/internal/authz) is live on /query and /dashboards, backed by a new enterprise/ module (session issuance, audit logging, RBAC storage, OIDC/SAML protocol wiring) that core never imports -- only calls over HTTP. Found and fixed a real cross-tenant vulnerability in dashboards (no tenant_id filtering at all) while writing the threat model doc. Two things are explicitly NOT done, documented rather than hidden: tenant isolation for log data itself (/query still shares one ClickHouse connection and Tantivy index across every tenant -- RBAC controls who can query, not what a query can see), and human SSO login (protocol wiring exists, no HTTP handler calls it yet). See docs/security/threat-model.md and docs/phase-4-runbook.md. Also adds deploy/ (Go Operator + Helm chart, validated offline only -- no cluster was reachable in this environment).
57 lines
1.7 KiB
Go
57 lines
1.7 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
)
|
|
|
|
func cmdDashboards(args []string, stdout, stderr io.Writer) int {
|
|
if len(args) == 0 {
|
|
fmt.Fprintln(stderr, "sentryctl dashboards: expected a subcommand (list, get, apply)")
|
|
return 1
|
|
}
|
|
apiURL, rest := extractAPIFlag(args[1:], os.Getenv)
|
|
token := resolveToken(os.Getenv)
|
|
|
|
switch args[0] {
|
|
case "list":
|
|
return httpGetJSON(apiURL, "/dashboards", token, stdout, stderr)
|
|
case "get":
|
|
if len(rest) == 0 {
|
|
fmt.Fprintln(stderr, "sentryctl dashboards get: missing dashboard id")
|
|
return 1
|
|
}
|
|
return httpGetJSON(apiURL, "/dashboards/"+rest[0], token, stdout, stderr)
|
|
case "apply":
|
|
if len(rest) == 0 {
|
|
fmt.Fprintln(stderr, "sentryctl dashboards apply: missing file path")
|
|
return 1
|
|
}
|
|
// The import endpoint consumes exactly the shape GET
|
|
// /dashboards/{id}/export produces and the web UI's Export JSON
|
|
// button downloads -- one JSON contract, three call sites.
|
|
return httpPostFileJSON(apiURL, "/dashboards/import", token, rest[0], stdout, stderr)
|
|
default:
|
|
fmt.Fprintf(stderr, "sentryctl dashboards: unknown subcommand %q (want list, get, apply)\n", args[0])
|
|
return 1
|
|
}
|
|
}
|
|
|
|
// extractAPIFlag pulls an optional --api <url> out of args, resolving
|
|
// the default the same way parsePingArgs/parseQueryArgs do, and returns
|
|
// the remaining positional args. Shared by dashboards and alerts since
|
|
// both take an optional --api/--alerting-api override the same way.
|
|
func extractAPIFlag(args []string, env func(string) string) (apiURL string, rest []string) {
|
|
apiURL = resolveAPIURL(env)
|
|
for i := 0; i < len(args); i++ {
|
|
if args[i] == "--api" && i+1 < len(args) {
|
|
apiURL = args[i+1]
|
|
i++
|
|
continue
|
|
}
|
|
rest = append(rest, args[i])
|
|
}
|
|
return apiURL, rest
|
|
}
|