coffey-labs/cairnobs
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix web/Dockerfile dropping two of its three VITE_* build args

Browse Source 
Only VITE_API_BASE_URL had a matching ARG/ENV pair; docker-compose.yml's
build args for VITE_ALERTING_API_BASE_URL and
VITE_ENTERPRISE_AUTH_BASE_URL were silently dropped by Docker (an
undeclared --build-arg is dropped, not an error). enterpriseAuthBase
came out undefined in the built bundle, so the tenant-picker page threw
"enterprise-auth is not configured" against a real running container
even though docker-compose.yml looked correct. The other two vars masked
this because web/src/lib/api.ts's apiBase/alertingBase both have
hardcoded fallbacks that happen to match the intended values.

Found while wiring a real Auth0 developer tenant into enterprise-auth to
close §3a/§12's remaining "real external IdP" gap. Also gitignores
docker-compose.override.yml, since that's where such real credentials
belong for local testing -- never committed.
This commit is contained in:
jcoffey-dev
2026-08-15 17:46:27 -07:00
parent 010f66ec70
commit 0452d1f921
2 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/Dockerfile
+16 -3
View File
@@ -7,11 +7,24 @@ WORKDIR /src
COPY package.json package-lock.json ./
RUN npm ci
COPY . .
# VITE_API_BASE_URL is baked in at build time — this is a prerendered
# static site, not a server. Override with --build-arg for non-default
# deployments.
# All three VITE_* vars are baked in at build time — this is a
# prerendered static site, not a server. Override with --build-arg for
# non-default deployments. Each one needs its own ARG: an undeclared
# --build-arg from docker-compose.yml's build.args is silently dropped
# by Docker, not an error -- confirmed the hard way when
# VITE_ALERTING_API_BASE_URL/VITE_ENTERPRISE_AUTH_BASE_URL were being
# passed in but only VITE_API_BASE_URL was ever declared here, so the
# other two never reached `npm run build` even though docker-compose.yml
# looked correct. VITE_ENTERPRISE_AUTH_BASE_URL has no default (unlike
# the other two) -- web/src/lib/api.ts treats it as intentionally
# undefined when unset, meaning "enterprise-auth isn't deployed", not
# "use some fallback host."
ARG VITE_API_BASE_URL=http://localhost:8080
ARG VITE_ALERTING_API_BASE_URL=http://localhost:8081
ARG VITE_ENTERPRISE_AUTH_BASE_URL
ENV VITE_API_BASE_URL=${VITE_API_BASE_URL}
ENV VITE_ALERTING_API_BASE_URL=${VITE_ALERTING_API_BASE_URL}
ENV VITE_ENTERPRISE_AUTH_BASE_URL=${VITE_ENTERPRISE_AUTH_BASE_URL}
RUN npm run build
# Not distroless: serving a static SPA needs *some* HTTP server, and